-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL auto-install. #1252
Fix SQL auto-install. #1252
Conversation
} | ||
} | ||
else | ||
{ | ||
return array("status"=>"failure","message"=>"Signature Definition file signature failed validation"); | ||
return array("status"=>"failure","message"=>"Signature Definition File Missing"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use gettext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. gettext here.
} | ||
else | ||
{ | ||
return array("status"=>"failure","message"=>"Signature Definition file signature failed validation"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use gettext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. gettext here.
} | ||
else | ||
{ | ||
array_push($signatureFailures, array("filename"=>$file->filename,"status"=>"File Missing")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use gettext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. This status is used in logic in other places. The user-facing text is already gettext'd in IntegrityCheck.php
$actualHash = sha1_file($CRMInstallRoot."/".$file->filename); | ||
if ( $actualHash != $file->sha1 ) | ||
{ | ||
array_push($signatureFailures, array("filename"=>$file->filename,"status"=>"Hash Mismatch", "expectedhash"=>$file->sha1,"actualhash"=>$actualHash)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gettext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. This status is used in logic in other places. The user-facing text is already gettext'd in IntegrityCheck.php
@DawoudIO take a look now - some of the things you suggested gettext for are not going to work - but I've addressed anything that ends up being displayed to the user. |
closes #1248
To test this: