Fix SQL auto-install. #1252
Merged
Fix SQL auto-install. #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawoudIO
reviewed
Nov 2, 2016
| } | ||
| } | ||
| else | ||
| { | ||
| return array("status"=>"failure","message"=>"Signature Definition file signature failed validation"); | ||
| return array("status"=>"failure","message"=>"Signature Definition File Missing"); |
There was a problem hiding this comment.
yes. gettext here.
| } | ||
| else | ||
| { | ||
| return array("status"=>"failure","message"=>"Signature Definition file signature failed validation"); |
There was a problem hiding this comment.
yes. gettext here.
| } | ||
| else | ||
| { | ||
| array_push($signatureFailures, array("filename"=>$file->filename,"status"=>"File Missing")); |
There was a problem hiding this comment.
no. This status is used in logic in other places. The user-facing text is already gettext'd in IntegrityCheck.php
| $actualHash = sha1_file($CRMInstallRoot."/".$file->filename); | ||
| if ( $actualHash != $file->sha1 ) | ||
| { | ||
| array_push($signatureFailures, array("filename"=>$file->filename,"status"=>"Hash Mismatch", "expectedhash"=>$file->sha1,"actualhash"=>$actualHash)); |
There was a problem hiding this comment.
no. This status is used in logic in other places. The user-facing text is already gettext'd in IntegrityCheck.php
|
@DawoudIO take a look now - some of the things you suggested gettext for are not going to work - but I've addressed anything that ends up being displayed to the user. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1248
To test this: